Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol-named properties do not need to align with string indexer type #21217

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

rbuckton
Copy link
Member

This fixes errors when declaring a type with a symbol-named property that also specifies a string indexer, as symbol-named properties do not collide with string indexers.

Fixes #20146

@rbuckton rbuckton requested review from weswigham and mhegazy January 16, 2018 23:46
@rbuckton rbuckton merged commit 7a89c96 into master Jan 17, 2018
@rbuckton rbuckton deleted the fix20146 branch January 17, 2018 01:01
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property '[mySymbol]' is not assignable to string index type
2 participants