Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add completion for method if the this parameter doesn't match #20616

Merged
1 commit merged into from
Dec 18, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2017

Fixes #20608

@ghost ghost requested a review from armanio123 December 11, 2017 16:05
@DanielRosenwasser
Copy link
Member

Are we okay with this change if it means you can't get completions to use .call, .bind, or .apply?

@ghost
Copy link
Author

ghost commented Dec 11, 2017

I would think so because it's unusual to do a.foo.call(b) when foo is a method. (This change wouldn't affect a property.)
If you meant that we wouldn't get completions for function f() {} f./**/, I don't see why, because call has a parameter this: Function and typeof f should be assignable to Function.

@ghost
Copy link
Author

ghost commented Dec 18, 2017

Waiting for confirmation from @DanielRosenwasser

@DanielRosenwasser
Copy link
Member

👍

@ghost ghost merged commit 1562a27 into master Dec 18, 2017
@ghost ghost deleted the completionsMethodWithThisParameter branch December 18, 2017 19:28
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants