Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fix add import require support #19802

Merged

Conversation

aluanhaddad
Copy link
Contributor

Fixes #

In this follow-up to #19572 code fixes that import a UMD module now prefer the import..require syntax when --module is commonjs, amd, or umd and synthetic defaults are not available.

@aluanhaddad aluanhaddad force-pushed the import-fix-add-import-require-support branch from ec865b7 to 853937e Compare November 7, 2017 16:57
@aluanhaddad aluanhaddad force-pushed the import-fix-add-import-require-support branch from 853937e to 555b4ae Compare November 7, 2017 17:09
@mhegazy mhegazy merged commit b2b54cb into microsoft:master Nov 7, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Nov 7, 2017

thanks!

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants