-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of Extract Constant #18783
Merged
Merged
Commits on Sep 27, 2017
-
Generalize extract method to handle constants as well
Major changes: 1) Instead of skipping undesirable scopes, include them and mark them with errors. Constants can be extracted into more scopes. 2) Update the tests to call through the "public" API. This caused some baseline changes. 3) Rename refactoring to "Extract Symbol" for generality. 4) Return a second ApplicableRefactorInfo for constants. Distinguish the two by splitting the action name.
Configuration menu - View commit details
-
Copy full SHA for 3eea1a9 - Browse repository at this point
Copy the full SHA 3eea1a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb1fb5c - Browse repository at this point
Copy the full SHA eb1fb5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2601bbc - Browse repository at this point
Copy the full SHA 2601bbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52ab05e - Browse repository at this point
Copy the full SHA 52ab05eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 697bce7 - Browse repository at this point
Copy the full SHA 697bce7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb6037b - Browse repository at this point
Copy the full SHA cb6037bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13e60bc - Browse repository at this point
Copy the full SHA 13e60bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6bfce1 - Browse repository at this point
Copy the full SHA e6bfce1View commit details
Commits on Sep 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 386e765 - Browse repository at this point
Copy the full SHA 386e765View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.