Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of Extract Constant #18783

Merged
merged 9 commits into from
Sep 28, 2017

Commits on Sep 27, 2017

  1. Generalize extract method to handle constants as well

    Major changes:
    
    1) Instead of skipping undesirable scopes, include them and mark them
    with errors.  Constants can be extracted into more scopes.
    
    2) Update the tests to call through the "public" API.  This caused some
    baseline changes.
    
    3) Rename refactoring to "Extract Symbol" for generality.
    
    4) Return a second ApplicableRefactorInfo for constants.  Distinguish
    the two by splitting the action name.
    amcasey committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    3eea1a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb1fb5c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2601bbc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    52ab05e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    697bce7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cb6037b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    13e60bc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e6bfce1 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2017

  1. Configuration menu
    Copy the full SHA
    386e765 View commit details
    Browse the repository at this point in the history