[es5.d.ts] Intl NumberFormat format function value can be string. #17737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/Microsoft/TypeScript/blob/a6a27ab66132087d889ded64373d42174e85f2fe/src/lib/es5.d.ts#L3970 Link to [documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NumberFormat/format). According to `es5.d.ts` interface Intl NumberFormat format function can only accept `number` value, but actually it can accept `string` too. For example: ```ts Intl.NumberFormat("en", { style: "currency", currency: "EUR" }).format("20.17"); ``` Result: ```ts "€20.17" ```
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
The type is limited to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Microsoft/TypeScript/blob/a6a27ab66132087d889ded64373d42174e85f2fe/src/lib/es5.d.ts#L3970
Link to documentation.
Link to specification.
According to
es5.d.tsinterface Intl NumberFormat format function can only acceptnumbervalue, but actually it can acceptstringtoo.For example:
Result:
"€20.17"Fixes #
number | string.