Don't count self-reference when setting isReferenced
#17495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
LGTM |
|
@andy-ms looks good. Nit: can you please update the comment at the change location to what you have in the description of this PR. that comment there is not that clear to understand. |
sheetalkamat
approved these changes
Aug 4, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16078
@aozgaa may be interested in poking holes in this.
In
resolveNameHelper, we climb up looking for a name, and we keep track of both the current location and the last location. If we got a symbol from the locals of the current location, and it'slastLocation, that means that we are insidelastLocationlooking up a name, and getting that node itself -- meaning it is a self-reference and should not be counted when considering--noUnusedLocals.