Code

Watch improvements in tsserver#17269

Code

Merged

sheetalkamat merged 128 commits intomastermicrosoft/TypeScript:masterfrom watchImprovementsmicrosoft/TypeScript:watchImprovementsCopy head branch name to clipboardOct 3, 2017

+8,737-3,279

Commits

Commits on Jul 10, 2017

• When opening a file, if it is using existing project, there is no need to update the project by re-reading the config file

  Show description for 21ad26b
  sheetalkamat

  committed
  21ad26b

• Restructure updating the configured project from disk and actual project update

  Show description for ae33ae8
  sheetalkamat

  committed
  ae33ae8

• Add project roots in the list of root files even if they arent present on the disk

  Show description for 75698a8
  sheetalkamat

  committed
  75698a8

• Move the server file system to handle watches on file/folder create, update and delete

  Show description for f154910
  sheetalkamat

  committed
  f154910

• Remove the functions to trigger watch callbacks now that it is auto on reloading FS

  sheetalkamat

  committed
  0e44367

• Update the todo list

  sheetalkamat

  committed
  2a63827

• Reload the configured project only once even though there are multiple files open from that project

  sheetalkamat

  committed
  96ffd53

• When config file is deleted, apart from removing the projecty, reload the configured projects for open files from that project to ensure to pick them by another config file that can be present in p…

  Show description for 6bd42b8
  sheetalkamat

  committed
  6bd42b8

• Optimize wildcard watchers and config directory watching as now we have missing file watching as well

  Show description for df6f75b
  sheetalkamat

  committed
  df6f75b

• Handle the deleted file in update graph better, so that in next update it is possible to schedule the update graph of project

  sheetalkamat

  committed
  9ff9476

Commits on Jul 11, 2017

• Only update file list when there are changes in the watched directories

  sheetalkamat

  committed
  62871cc

• Update types instantly when the type root changes.

  sheetalkamat

  committed
  48c6513

Commits on Jul 12, 2017

• Cache the read directory results so that it doesnt end up reading it all the time

  sheetalkamat

  committed
  19a6a00

• Use the cached file exists/directory exists for configured project since we watch the needed files

  sheetalkamat

  committed
  68def1b

• Fixes the fourslash runner tests by handling hosts that cannot support read directory or getDirectories

  sheetalkamat

  committed
  029b1f2

• Remove the done TODO

  sheetalkamat

  committed
  f338a70

Commits on Jul 13, 2017

• TODOs for the scheduling update graph and referesh projects

  sheetalkamat

  committed
  8fedcf7

• Allows the delayed update graph and project structure which helps in batching the updates when there are multiple files added/removed/changed

  sheetalkamat

  committed
  e568976

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  048e67c

• use single instance of getCanonicalFileName

  sheetalkamat

  committed
  0365901

Commits on Jul 15, 2017

• Logging of the watch add/remove/event

  sheetalkamat

  committed
  404aa8f

• Some refactoring to combine files removal from inferred project

  sheetalkamat

  committed
  71d79c6

• Remove the duplcate error about no input files found

  sheetalkamat

  committed
  f12980d

• Refactor root files addition/update for non inferred project

  sheetalkamat

  committed
  00011a5

Commits on Jul 16, 2017

• Instead of watching directories, watch tsconfig files of inferred project root

  sheetalkamat

  committed
  0572b15

• Use map for configured project instead of the array

  sheetalkamat

  committed
  62663a1

• Combine the logic to find config file as well as the watch.

  Show description for dcbd7b1
  sheetalkamat

  committed
  dcbd7b1

Commits on Jul 17, 2017

• Added another todo as now we are watching too many files

  sheetalkamat

  committed
  62ef6b1

• Reduce the number of watched config files by watching the chain only in case of inferred root

  sheetalkamat

  committed
  2439e7a

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  ff34a77

Commits on Jul 20, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  1155c37

Commits on Aug 7, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  ae87838

• Refactoring of the builder

  sheetalkamat

  committed
  802e283

• Do not update graph in builder if compile on save is not on

  sheetalkamat

  committed
  499fabc

• Make the host cache store the fileName instead of undefined for the missing host files

  sheetalkamat

  committed
  273569f

• Program cannot be reused if the missing file is now present

  Show description for 94a589b
  sheetalkamat

  committed
  94a589b

• Initial refactoring so that watch from tsc follows the tsserver projects

  sheetalkamat

  committed
  ef5935b

• Refactor so that builder handles only source files and program

  sheetalkamat

  committed
  e068475

• Move the builder to compiler directory

  sheetalkamat

  committed
  6237b22

• Use builder to emit the files from the tsc.js

  sheetalkamat

  committed
  9b18f7b

• Refactor out the tsc logic into another file so we can use that to test it out

  sheetalkamat

  committed
  85b9254

• Refactor watched system from tsserver tests so that tscLib watch can leverage it

  sheetalkamat

  committed
  69e5abd

• Add tests for the tsc --watch

  sheetalkamat

  committed
  c814d8e

• Emit tests

  sheetalkamat

  committed
  2dd6aed

• Modify the api in builder so that it tracks changed files

  sheetalkamat

  committed
  89c61e7

• Add tests to verify emitted files

  sheetalkamat

  committed
  bb91b32

• Refactoring so that instead of just using from tsc --watch the new api is accessible all the time

  sheetalkamat

  committed
  46e3d1c

• Switch back to have tsc.ts the only file thats different in tsc.js generation now that api has tests

  sheetalkamat

  committed
  031a637

• Use cache for module resolution even in watch mode

  sheetalkamat

  committed
  0d5e6c9

• Test for the module resolution caching

  sheetalkamat

  committed
  2762232

• Add test that fails because we dont watch module resolutions failed paths

  sheetalkamat

  committed
  65a6ee0

• Implementation of watching the failed lookup locations

  sheetalkamat

  committed
  d55150c

• Partial implementation for invalidating the program (instead of source file as that would involve more work) so the files are picked up

  sheetalkamat

  committed
  8dc6248

• Implementation for invalidating source file containing possibly changed module resolution

  sheetalkamat

  committed
  7474ba7

• Get semantic diagnostics for the program from builder so that it caches the errors of unchanged files

  sheetalkamat

  committed
  6385f7e

Commits on Aug 8, 2017

• Feedback from the PR

  sheetalkamat

  committed
  65521bc

Commits on Aug 10, 2017

• More updates based on PR feedback

  sheetalkamat

  committed
  27988bf

• More work on PR feedback

  sheetalkamat

  committed
  02b8a7d

Commits on Aug 11, 2017

• More updates per PR feedback

  sheetalkamat

  committed
  f723beb

• More work on feedback from PR

  sheetalkamat

  committed
  b071a86

• More work on PR feedback update

  sheetalkamat

  committed
  8db05c2

Commits on Aug 12, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  594482d

• Merge branch 'watchImprovements' into builder

  sheetalkamat

  committed
  d0a23bb

Commits on Aug 14, 2017

• Simplified mutate map options

  sheetalkamat

  committed
  59d07dc

• Updating according to feedback from PR

  sheetalkamat

  committed
  9895082

• More work based on feedback

  sheetalkamat

  committed
  f1b1b12

• Update based on feedback

  sheetalkamat

  committed
  136b091

Commits on Aug 15, 2017

• Update to PR feedback

  sheetalkamat

  committed
  6bf9133

• Make the failedLookuplocations to be readonly array

  sheetalkamat

  committed
  a99c04e

Commits on Aug 18, 2017

• Update based on feedback

  sheetalkamat

  committed
  b66b752

• Made updates to not expose methods/types that arent needed.

  sheetalkamat

  committed
  da0d374

• Merge branch 'watchImprovements' into builder

  sheetalkamat

  committed
  e639ceb

• Remove the unused function from the Project since builder has this logic now.

  sheetalkamat

  committed
  8deef58

• When getting default project from session, get it only if the script info is not orphan

  Show description for c425128
  sheetalkamat

  committed
  c425128

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  d217bec

• Merge branch 'watchImprovements' into builder

  sheetalkamat

  committed
  60e2e68

Commits on Aug 21, 2017

• More PR feedback work

  sheetalkamat

  committed
  84b2e23

• Merge branch 'watchImprovements' into builder

  sheetalkamat

  committed
  3908325

Commits on Aug 22, 2017

• Adding test for #16329 to verify the caching of file system when opening file

  sheetalkamat

  committed
  7173da2

• Adding test for #16456 to verify watched directories in case-sensitive and non sensitive file system and fixing caching

  sheetalkamat

  committed
  e500be2

• In Server when polling the file stat's do not send changed event in case the file doesnt exist.

  sheetalkamat

  committed
  6227a36

• Update the failed lookup watches without doing lookups.

  Show description for 55931c4
  sheetalkamat

  committed
  55931c4

• Add test for #16955 which simulates npm install

  sheetalkamat

  committed
  e65df12

• Add api in builder to get changed files and use it to send project changed event

  sheetalkamat

  committed
  e711238

Commits on Aug 23, 2017

• Add tests to verify project changed event sent

  sheetalkamat

  committed
  3b85f3f

Commits on Aug 31, 2017

• Merge pull request #17820 from Microsoft/tsserverEventChangedFiles

  Show description for ea95f3b
  sheetalkamat

  authored
  ea95f3b

• Merge pull request #17669 from Microsoft/builder

  Show description for 9e570c3
  sheetalkamat

  authored
  9e570c3

• Refactoring to watches and caching of system such that we minimize function expressions

  Show description for 4c79033
  sheetalkamat

  committed
  4c79033

• Reduce number of watches for failed lookup locations as part of module resolution

  sheetalkamat

  committed
  5aafd3f

• Handle watches of missing directories and make project the module resolution host

  sheetalkamat

  committed
  17565d8

• Script infos while opening/closing shouldnt mark project as dirty if the contents dont change

  sheetalkamat

  committed
  10ea5bf

• Watch failed lookups recursively to reduce number of directory watches

  Show description for 254e393
  sheetalkamat

  committed
  254e393

• Resolve only once in the given directory for name

  sheetalkamat

  committed
  a3b9467

• Watch for the automatic types that included as part of type resolution

  sheetalkamat

  committed
  16cf7c4

• Watch node_modules if possible

  sheetalkamat

  committed
  d7ce95d

• Update tests

  sheetalkamat

  committed
  345f36d

• Print number of files in the project when printing project

  sheetalkamat

  committed
  2b97b2c

• Reduce storage of maps/sets for failed lookups

  sheetalkamat

  committed
  8d5d4c2

Commits on Sep 1, 2017

• Remove the configured project if on next open file if it has no open files instead of immediately when closing last open file

  sheetalkamat

  committed
  9e5e20c

• Update tests

  sheetalkamat

  committed
  13aafa2

• Test to verify calls to isProgramUptoDate return true when there is no change in compiler options

  sheetalkamat

  committed
  6c61293

Commits on Sep 5, 2017

• Revert to use refcount to keep track of directory watchers for failed lookup

  sheetalkamat

  committed
  7b2bab5

Commits on Sep 6, 2017

• Resolution is valid unless it is invalidated

  sheetalkamat

  committed
  54f64a1

• Add files to change set instead of delay reloading project on "change" command

  sheetalkamat

  committed
  0ff160f

• Update how we get project/script info so that it doesnt start unnecessary update graph

  sheetalkamat

  committed
  e6eede1

• Reduce the file size for npm install test

  sheetalkamat

  committed
  2a5d954

• Better log for update graph and delay operations

  sheetalkamat

  committed
  680994e

Commits on Sep 7, 2017

• Invalidate resolution of the failed lookup only if its one of the default extension or is one of the failed lookup location without that default extension

  sheetalkamat

  committed
  c8e711c

• Update the test cases for project changed event since it doesnt apply to the edits to open files

  sheetalkamat

  committed
  29e93c3

• Return configured project being closed by config file

  sheetalkamat

  committed
  b179cd1

Commits on Sep 8, 2017

• Limit the resolution invalidation to max number of files as invalidation for larger cache might take more time than to just recalculate resolutions

  sheetalkamat

  committed
  67f9533

• Add test case to verify correct resolution file is picked when current resolution file is not removed but higher precedence file is created

  sheetalkamat

  committed
  de28d02

Commits on Sep 9, 2017

• Do not create map just to store empty reference files. Also update file as changed if file text is same but it had invalidated resolution

  sheetalkamat

  committed
  5739b68

Commits on Sep 11, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  fdb104b

Commits on Sep 12, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  aea8630

• Should not remove the reused resolutions in the file when file contents have not changed.

  sheetalkamat

  committed
  b536f9d

Commits on Sep 13, 2017

• Simplify event sent on background project update since its anyways just to update the error list

  sheetalkamat

  committed
  4f7c0e5

Commits on Sep 14, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  cf72f2a

Commits on Sep 25, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  23acff5

Commits on Sep 26, 2017

• Rename watchedProgram.ts to watch.ts

  sheetalkamat

  committed
  14febe2

• Renamed PartialSystem as DirectoryStructureHost and CachedPartialSystem as CachedDirectoryStructureHost

  sheetalkamat

  committed
  38f3a2b

• PR feedback

  sheetalkamat

  committed
  68d3605

Commits on Sep 29, 2017

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  9e08cae

Commits on Oct 2, 2017

• PR feedback

  sheetalkamat

  committed
  835153b

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  898559b

• Making APIs as internal so that we can enable them after we have figured out final details

  sheetalkamat

  committed
  7f969e8

• Merge branch 'master' into watchImprovements

  sheetalkamat

  committed
  4bb4711

Commits on Oct 3, 2017

• Separate namespace declarations in builder of intenal and exported interfaces and functions

  sheetalkamat

  committed
  8ac01d7