Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups in builder #17208

Merged
2 commits merged into from
Jul 17, 2017
Merged

Minor cleanups in builder #17208

2 commits merged into from
Jul 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2017

Add insertSorted and removeSorted to server utilities.

@ghost ghost requested a review from sheetalkamat July 14, 2017 21:03
sheetalkamat
sheetalkamat reviewed Jul 15, 2017
View reviewed changes
src/server/builder.ts Outdated
// Equal. Go to next
oldIndex++;
newIndex++;
switch (compare) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given you have c;leaned this up, is it possible to use enumerate inserted and deleted from utilities instead

sheetalkamat
sheetalkamat approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

@ghost ghost merged commit 555776e into master Jul 17, 2017
@ghost ghost deleted the builder branch July 17, 2017 19:24
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheetalkamat @msftclas