Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsserverProjectSystem.ts: Remove unnecessary 'export's #17201

Merged
2 commits merged into from
Aug 8, 2017
Merged

tsserverProjectSystem.ts: Remove unnecessary 'export's #17201

2 commits merged into from
Aug 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2017

Most of the exports in this file were never used.

@ghost ghost requested a review from jramsay July 14, 2017 17:42
Copy link
Member

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

@@ -28,7 +28,7 @@ namespace ts.projectSystem {
})
};

export interface PostExecAction {
interface PostExecAction {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostExecAction is referenced by a protected property in TestTypingsInstaller. While this isn't necessarily an error now, it would be if we were to set "declarations": true in our tsconfig.json.

@rbuckton
Copy link
Member

rbuckton commented Aug 8, 2017

👍

@ghost ghost merged commit eb8bcd7 into master Aug 8, 2017
@ghost ghost deleted the unexport branch August 8, 2017 18:02
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants