Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse stored types for any[] and Promise<any> instead of creating new ones #17179

Merged
2 commits merged into from
Jul 17, 2017
Merged

Reuse stored types for any[] and Promise<any> instead of creating new ones #17179

2 commits merged into from
Jul 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2017

No description provided.

@ghost ghost requested a review from sandersn July 13, 2017 21:34
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jul 14, 2017 •
edited
Loading

Looks good to me, but the Promise<any> case doesn't seem to be covered.

@ghost
Copy link
Author

ghost commented Jul 14, 2017

createPromiseType has side effects, so we can't do that up-front.

@ghost ghost merged commit 5d46ca7 into master Jul 17, 2017
@ghost ghost deleted the anyArray branch July 17, 2017 19:57
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRosenwasser @msftclas