Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse jsdoc with normal TS type parser #17176

Merged
merged 14 commits into from
Jul 17, 2017
Merged

Commits on Jul 13, 2017

  1. Parse JSDoc types using the normal TS parser

    This means that JSDoc types can include the full range of Typescript
    types now. It also means that Typescript annotations can include JSDoc
    types. This is disallowed with a new error, however. But Typescript can
    still give the correct types to JSDoc that shows up in .ts files by
    mistake. This can easily happen, for example with types like
    
    ```ts
    var x: number? = null;
    var y: ?string = null;
    var z: function(string,string): string = (s,t) => s + t;
    
    // less likely to show up, but still understood.
    var ka: ? = 1;
    ```
    
    In the future, I will add a quick fix to convert these into the correct
    types.
    
    Fixes #16550
    sandersn committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    bc69c7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91633cd View commit details
    Browse the repository at this point in the history
  3. Update baselines

    sandersn committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    48d9012 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ac478a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d24b3a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2017

  1. Update baselines

    sandersn committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    da5285e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e861fd View commit details
    Browse the repository at this point in the history
  3. Improve JSDoc function checking

    1. Remove checkJSDocFunctionType in favour of checkSignature.
    2. Check that 'new', in addition to 'this', must be the first parameter.
    3. Remove prematurely added JSDoc-quickfix test.
    sandersn committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    f1145c3 View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    40ae422 View commit details
    Browse the repository at this point in the history
  5. Update baselines

    sandersn committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    b2e892f View commit details
    Browse the repository at this point in the history
  6. Address more PR comments

    sandersn committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    bdc3f1f View commit details
    Browse the repository at this point in the history
  7. Parse more types in JSDoc function() syntax

    Also some cleanup from PR comments
    sandersn committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    172db13 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    61c9f98 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2017

  1. Configuration menu
    Copy the full SHA
    3f60364 View commit details
    Browse the repository at this point in the history