-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse jsdoc with normal TS type parser #17176
Merged
Merged
Commits on Jul 13, 2017
-
Parse JSDoc types using the normal TS parser
This means that JSDoc types can include the full range of Typescript types now. It also means that Typescript annotations can include JSDoc types. This is disallowed with a new error, however. But Typescript can still give the correct types to JSDoc that shows up in .ts files by mistake. This can easily happen, for example with types like ```ts var x: number? = null; var y: ?string = null; var z: function(string,string): string = (s,t) => s + t; // less likely to show up, but still understood. var ka: ? = 1; ``` In the future, I will add a quick fix to convert these into the correct types. Fixes #16550
Configuration menu - View commit details
-
Copy full SHA for bc69c7e - Browse repository at this point
Copy the full SHA bc69c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91633cd - Browse repository at this point
Copy the full SHA 91633cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48d9012 - Browse repository at this point
Copy the full SHA 48d9012View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac478a9 - Browse repository at this point
Copy the full SHA ac478a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d24b3a3 - Browse repository at this point
Copy the full SHA d24b3a3View commit details
Commits on Jul 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for da5285e - Browse repository at this point
Copy the full SHA da5285eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e861fd - Browse repository at this point
Copy the full SHA 6e861fdView commit details -
Improve JSDoc function checking
1. Remove checkJSDocFunctionType in favour of checkSignature. 2. Check that 'new', in addition to 'this', must be the first parameter. 3. Remove prematurely added JSDoc-quickfix test.
Configuration menu - View commit details
-
Copy full SHA for f1145c3 - Browse repository at this point
Copy the full SHA f1145c3View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 40ae422 - Browse repository at this point
Copy the full SHA 40ae422View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2e892f - Browse repository at this point
Copy the full SHA b2e892fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdc3f1f - Browse repository at this point
Copy the full SHA bdc3f1fView commit details -
Parse more types in JSDoc function() syntax
Also some cleanup from PR comments
Configuration menu - View commit details
-
Copy full SHA for 172db13 - Browse repository at this point
Copy the full SHA 172db13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61c9f98 - Browse repository at this point
Copy the full SHA 61c9f98View commit details
Commits on Jul 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3f60364 - Browse repository at this point
Copy the full SHA 3f60364View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.