Fix #15463: use intersection types to emulate spread in generic react components #15851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
May 15, 2017
src/compiler/checker.ts
Outdated
|
|
||
| const attributeType = createJsxAttributesType(attributes.symbol, attributesTable); | ||
|
|
||
| return typeToIntersect ? attributesTable.size ? getIntersectionType([typeToIntersect, attributeType]) : typeToIntersect : attributeType; |
There was a problem hiding this comment.
what about a flatter form?
typeToIntersect && attributesTable.size ? getIntersectionType([typeToIntersect, attributeType]) :
typeToIntersect ? typeToIntersect : attributeType |
|
||
| const attributeType = createJsxAttributesType(attributes.symbol, attributesTable); | ||
| return typeToIntersect && attributesTable.size ? getIntersectionType([typeToIntersect, attributeType]) : | ||
| typeToIntersect ? typeToIntersect : attributeType; |
There was a problem hiding this comment.
Consider
if (typeToIntersect) {
if (attributesTable.size) {
return getIntersectionType([typeToIntersect, attributeType]);
}
return typeToIntersect;
}
return attributeType;There was a problem hiding this comment.
We use the ternary operator quite often. so do not think this is out of line here.
There was a problem hiding this comment.
You would save one condition and make it way easier to read in this case tho
DanielRosenwasser
requested changes
May 15, 2017
src/compiler/checker.ts
Outdated
| if (isTypeAny(exprType)) { | ||
| hasSpreadAnyType = true; | ||
| } | ||
| spread = getSpreadType(spread, exprType); | ||
| if (!isValidSpreadType(exprType)) { |
There was a problem hiding this comment.
Invert the condition here and flip them around 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15463