Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow export default abstract class. Related to issue 3792. #14657

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Allow export default abstract class. Related to issue 3792. #14657

merged 1 commit into from
Mar 31, 2017

Conversation

erikmcc
Copy link
Contributor

@erikmcc erikmcc commented Mar 14, 2017 •
edited
Loading

Fixes (part of) #3792

@msftclas
Copy link

@erikmcc,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@erikmcc, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

DanielRosenwasser
DanielRosenwasser approved these changes Mar 31, 2017
View reviewed changes
tests/baselines/reference/classAbstractManyKeywords.errors.txt
tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractManyKeywords.ts(3,1): error TS1128: Declaration or statement expected.
tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractManyKeywords.ts(4,17): error TS1005: '=' expected.


==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractManyKeywords.ts (3 errors) ====
==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractManyKeywords.ts (2 errors) ====
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow nice test name @aozgaa

@DanielRosenwasser
Copy link
Member

👍 LGTM

@sandersn sandersn merged commit a62869c into microsoft:master Mar 31, 2017
@aluanhaddad
Copy link
Contributor

Awesome!

It is a shame this doesn't support interfaces. I tend to abide by the rule that says if you have only one export, it should be the default, and I apply this even to interfaces.

Regardless, I'm really glad to see this. Thank you!

@erikmcc
Copy link
Contributor Author

erikmcc commented Mar 31, 2017 via email

@mhegazy mhegazy mentioned this pull request May 23, 2017
Open
@BehindTheMath
Copy link

@erikmcc Does it make sense that I'm still getting an error if I use the export = syntax (for example, export = abstract class A)?

@mhegazy
Copy link
Contributor

mhegazy commented Oct 9, 2017

We are not planning on changing the export = at the time being.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@erikmcc @msftclas @DanielRosenwasser @aluanhaddad @BehindTheMath @mhegazy @sandersn