Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update declaration file to use intrinsic object type #13350

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

HerringtonDarkholme
Copy link
Contributor

Follow #12501, update declaration files to use intrinsic object type.

Only methods unconditionally throwing runtime TypeError are patched. For example, Object.keys invoked with primitive type will only throw TypeError in ES5. If we patch such methods, we will break partially ES6 compatible client.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 9, 2017

@RyanCavanaugh can you take a look.

@falsandtru
Copy link
Contributor

falsandtru commented Jan 18, 2017

@HerringtonDarkholme Can you also update declarations in the lib directory?

@RyanCavanaugh
Copy link
Member

Looks right to me

@HerringtonDarkholme
Copy link
Contributor Author

@falsandtru I think the lib directory will be automatically updated in next release. So no need to update in this pull request.

@falsandtru
Copy link
Contributor

Oh, I don't know that automation, thanks.

@eschwartz
Copy link

I just want to note that this breaks the @types/lodash package. It seems like a bad move on the part of the lodash typings to include standard node library definitions... but they probably have good reasons.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants