Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type alias display #12068

Merged
merged 5 commits into from
Nov 8, 2016
Merged

Fix type alias display #12068

merged 5 commits into from
Nov 8, 2016

Conversation

ahejlsberg
Copy link
Member

Fixes #10337 and #12066.

@ahejlsberg
Copy link
Member Author

@mhegazy @yuit This one properly fixes the issues we had with displaying generic type aliases. We may need to port these changes to other branches.

sheetalkamat
sheetalkamat reviewed Nov 8, 2016
View reviewed changes
tests/baselines/reference/instantiatedTypeAliasDisplay.types
@@ -0,0 +1,66 @@
=== tests/cases/compiler/instantiatedTypeAliasDisplay.ts ===
// Repros from #12066
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add //@declaration: true to make sure declaration emitter behaves correctly too.
Thanks

@ahejlsberg ahejlsberg merged commit 2282477 into master Nov 8, 2016
@ahejlsberg ahejlsberg deleted the fixTypeAliasDisplay branch November 8, 2016 14:43
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sheetalkamat sheetalkamat sheetalkamat left review comments

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahejlsberg @mhegazy @sheetalkamat @msftclas