Cache generic signature instantiations #12064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
reviewed
Nov 8, 2016
| @@ -25,8 +25,6 @@ tests/cases/compiler/promisePermutations.ts(106,19): error TS2345: Argument of t | |||
| Types of parameters 'cb' and 'value' are incompatible. | |||
| Type 'string' is not assignable to type '<T>(a: T) => T'. | |||
| tests/cases/compiler/promisePermutations.ts(109,19): error TS2345: Argument of type '(cb: <T>(a: T) => T) => IPromise<string>' is not assignable to parameter of type '(value: string) => IPromise<string>'. | |||
| Types of parameters 'cb' and 'value' are incompatible. | |||
There was a problem hiding this comment.
Isnt this error something we want to show even if we are using cached signature
There was a problem hiding this comment.
We have already shown it in a previous elaboration. The reason it is going away is that we do a better job of sharing identical types, so you'll see less redundant elaborations. This is the expected behavior.
sheetalkamat
approved these changes
Nov 8, 2016
vladima
approved these changes
Nov 8, 2016
mhegazy
approved these changes
Nov 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching of generic signature instantiations. We already cache instantiations of generic classes, interfaces, and type aliases, but oddly we have never done similar caching of generic signature instantiations. Other than just reducing redundant work, this should have a positive effect on generic signatures that return anonymous types (or instantiations of type aliases for anonymous types) since those continually manufacture new type identities.