Lock tslint version to 4.0.0-dev.0, because 4.0.0-dev.1 complains about unnecessary semicolons following properties #12021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut unnecessary semicolons following properties
|
sorry, looking at the lint failures on https://github.com/Microsoft/TypeScript/blob/ab75ea75d337d82138083c52caea7419f3b20929/src/harness/unittests/tsserverProjectSystem.ts#L520, these look like false positives. the rule shouldn't flag unnecessary semicolons on single line lambdas (they look like simple properties). will get this fixed in the next dev release. |
sandersn
approved these changes
Nov 3, 2016
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix my broken build in #11993. (Jenkins correctly uses the latest tslint and errors, while travis seems to be using the old tslint.)