Move module transformers to end of transformations #11769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
changed the title
vladima
approved these changes
Oct 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the transformers for ES2015, CommonJS, AMD, UMD, and System to the end of the transformation chain. In addition this cleans up the various module transformers to be more consistent.
This will allow us to isolate emit helpers to specific transformations, which was blocked by the fact that the module transformation happened very early in the transformation chain.
This also fixes a compiler crash when emitting a destructuring assignment with a destructuring target of an exported variable with
--module system.Fixes #11770