Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This code needs a lot of cleanup; posted this as soon as I could get good performance numbers. I'll refactor it later if it looks like we will go ahead with this. Tests pass; travis is failing in the linter.
Memory performance numbers are lot more stable than time, and show a consistent 5% benefit.
The code without maps uses the same amount of memory, because we do not use a shim: we use a dictionary-mode object directly.
It works like this:
With similar conditions on every map-using function. e.g.:
Map
is an interface containing only a brand, so it can't be used directly, only through these functions. It's like an abstract data type.Performance
Tested with the vscode source code.
Current
(
tsc -p src --noEmit --diagnostics
wheretsc --version
is2.1.0-dev.20160928
)I use
--noEmit
because the emit phase is dominated by I/O write time.Native maps
New code without native maps
(Latest version of node, running this branch with the code changed to disable using native maps.)