-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension loading and management tools #10159
Conversation
9ecd10c
to
5541571
Compare
8ee57f3
to
5ad76bd
Compare
@@ -2,6 +2,17 @@ | |||
/// <reference path="performance.ts" /> | |||
|
|||
|
|||
namespace ts { | |||
export function startsWith(str: string, prefix: string): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is this intentional to not mark "internal"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aye. It was a useful tool which I was using in my tests. I could just copy
it, I suppose, if having them public is an issue.
On Thu, Aug 11, 2016, 2:40 PM Yui [email protected] wrote:
In src/compiler/core.ts
#10159 (comment):@@ -2,6 +2,17 @@
///+namespace ts {
- export function startsWith(str: string, prefix: string): boolean {
question: is this intentional to not mark "internal"?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/pull/10159/files/5ad76bd5fdd630ddc580ac497fc98d44f9acd4d1#r74508706,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACzAMigcs3CcrH9FBPolH9QTfGOZ7QNbks5qe5bPgaJpZM4JdPPR
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it will be an issue. I was just curious :)
5ad76bd
to
445d7f7
Compare
@@ -2824,14 +2824,25 @@ | |||
"category": "Message", | |||
"code": 6136 | |||
}, | |||
"No types specified in 'package.json' but 'allowJs' is set, so returning 'main' value of '{0}'": { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space?
…Implement loadExtension on LSHost
445d7f7
to
d8aec99
Compare
closing in favor of #12231. More docs available at https://github.com/Microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin. |
From #9038, this PR contains just the framework for specifying, loading, testing, and otherwise managing compiler extensions.
Most of this PR (in terms of lines of code) is just a test harness for compiling, running, and verifying extensions.
@ahejlsberg @vladima @rbuckton @mhegazy We can vet and merge this framework, and then proceed to expose extensibility points as they are ready.