Paste into editor with format on paste removes pasted word

[bpasero]

TS Template added by @mjbvz

TypeScript Version: @4.7.0-dev.20220222

Search Terms

• Format on paste
• format

---

I have auto save enabled and format on paste. When I paste a string into a another string, that string is removed. See

//cc @sandy081

[hediet]

I cannot reproduce this on windows. Up for a quick meeting?

[bpasero]

Yes

[bpasero]

Henning figured out that this is a bug in the typescript formatter and it reproduces as simple as with this:

const x = f('aaaa', 'aaaa').x()

When you try to paste the aaaa into the second location.

[mjbvz]

Here's the format request I see pasting into the first argument in the above example:

[Trace  - 00:27:06.888] <syntax> Sending request: format (5). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/san/index.ts",
    "line": 1,
    "offset": 14,
    "endLine": 1,
    "endOffset": 18
}
[Trace  - 00:27:06.919] <syntax> Response received: format (5). Request took 32 ms. Success: true 
Result: [
    {
        "start": {
            "line": 1,
            "offset": 13
        },
        "end": {
            "line": 1,
            "offset": 23
        },
        "newText": ""
    }
]

[RyanCavanaugh]

Repro explained:

Turn on Format on Paste, then write

const a = f('').x();

Put the caret between the quotes and paste bar (or anything really?) and the new text is

const a = f().x();

instead of

const a = f('bar').x();

[mjbvz]

@RyanCavanaugh I'm marking this as a VSCode priority for 4.7 as we've seen a few reports of it now

[sandersn]

So far, it looks like the tree walking part of the formatter doesn't correctly increment the scanner, so the end-of-tree section of the code ends up formatting ( ) instead of ( "bar".

Now I have to go understand how the tree walk works.

[sandersn]

Broken in #46875, which is not surprising since that PR adds the end-of-tree section.

Edit: The tree walk was probably already incorrect, it's just the new end-of-tree code relies on it being correct.

[DarinDev1000]

I also have this issue on mac