-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Partial Type Argument Inference #26242
Comments
My vote is for either 1 or 3b :) |
Maybe adopt the foo<?, ?, string>(); // returns [{}, {}, string] which already stands for type Foo<T, U, V> = T | U | V;
type Bar = Foo<?, string, ?>; // equal to type Bar<A, B> = A | string | B; |
Will this include the option for simply omitting trailing type arguments, and having them automatically set as inferred? Ie for these to be equivalent:
|
@jsiwhitehead consider: declare const foo: {
<A, B>(): A & B;
<A>(): A;
};
foo<string>(); // The signature this refers to would be ambiguous if `infer`s were autofilled So I don't think so - those likely won't be equivalent. |
@weswigham sorry I wasn't fully clear, I meant in the case when the trailing type arguments are optional / have defaults, so in situations where they can already be left out. The change I'm asking about is how the unprovided optional types are resolved. Currently there are two different cases:
Hopefully this proposal for partial inference could include allowing inference to continue working in the second case (as requested in #19205, which is closed as a duplicate of #10571). E.g. declare function foo<A, B = any>(b: B): [A, B];
foo<number>(null); // Resolves to [number, any], should resolve to [number, null] Or does that also lead to new ambiguities? |
In your example no, for more complex types with multiple signatures, yes. It's also technically a break to do that since we'd suddenly be doing inference where previously people we relying on defaults. By making it explicit with |
I'm struggling to see how this could lead to an ambiguity that wasn't already there sorry, even with multiple signatures. The change I'm asking about is only about how unprovided type arguments are resolved, not about the process Typescript uses to choose which signature to use. E.g. there is an ambiguity in the following, but that is the case already, and currently is just resolved by taking the first possible match, which is fine. declare const foo: {
<A, B = any>(b: B): [A, B];
<A>(b: any): A;
};
foo<string>(null); // This resolves to [string, any], but should resolve to [string, null] Sorry to keep digging on this, but I'm trying to type a selector based API which will be vastly less usable if infer has to be written for all types: do<string>('key1', 'key2', ..., 'keyN', (value1, value2, ..., valueN) => ...) vs do<string, infer, infer, ..., infer (N times)>('key1', 'key2', ..., 'keyN', (value1, value2, ..., valueN) => ...) Of course, if the fact that this would technically be a break means it's a no go either way, then that's just how it is! |
@weswigham We are wondering how this feature would play with a new encoding we're likely to use in Given: right: <L = never, A = 'reason is you cannot partially bind Type Params to `right`'>(a: A) => Either<L, typeof a> What would be the typing for: // x3: Either<string, number> or Either<string, ???>
const x3 = right<string, infer>(1) The thread is discussed here: Thanks in advance. |
Not sure if I'm a little late to the game here but I'd like to give a simple use case for when this might be be useful. Given the following: interface Options<S = {}, Payloads = {}> {
reducers: {
[key in keyof Payloads]: (state: S, payload: Payloads[key]) => S
}
state: S
}
function identity<S, Payloads = {}>
(options: Options<S, Payloads>): Options<S, Payloads> {
return options
}
const options = {
reducers: {
add: (state, payload: number) => ({
...state,
answer: state.answer + payload
})
},
state: {
answer: 42
}
} Type inference works wonderfully as expected when no type arguments are supplied to the // Both State and ReducerPayloads are inferred correctly provider `state` and `payload` type safety
const fullyInferred = identity(options) When one explicitly types the // When explicitly specifying the State however, ReducerPayloads is no longer inferred and
// defaults to {}. We effectively lose type inference for `partiallyInferred.reducers`
const partiallyInferred = identity<{ answer: number }>(options) Using const partiallyInferred = identity<{ answer: number }, infer>(options) If there's already a means of achieving this partial inference in this example, feel free to share it here as it would seem quite useful. |
@jsiwhitehead I feel your pain, I've been writing an API that uses a type involving many generic string literals (they are used to build action creators for ngrx). It's annoying having to iterate every argument even with the version of typescript from this branch. I wonder if maybe a trailing <T, *, *, *, *, *>() => {} where the last 5 here are string literals and I need to add a new <T, **>() => {} to infer all subsequent generics |
@ohjames I like that. Further, that: <T>() => {} is equivalent to <T, **>() => {} |
@flushentitypacket Yes, I wish the language was designed that way in the first place, however now it's too late to implement things that way, given it will conflict with default generic parameters? |
Maybe, a trailing "elided entry" could imply all remaining parameters are inferred. <T,>() => {} edit: Actually, this would be an issue for multi-line parameters. |
related: #21984 |
Could you simply make trailing types optional, while making leading types required? It would fully depend on how the types were ordered, but I see that as a feature rather than a limitation. Optional function arguments work similarly. Given: declare foo<A,B,C>(): [A, B, C]; This means you can do any of these: foo()
foo<string>()
foo<string,string>()
foo<string,string,string>() But not: foo<,string>()
foo<,,string>()
foo<,string,string>()
foo<,string,>() This wouldn't require any special syntax parsing. It would simply fix the expected arguments error. |
@lukescott That proposal is here: #10571 |
@ohjames I do see omitting trailing types mentioned in #10571, but it looks like it advocates for an |
@lukescott read the initial comment on that issue, the talk of Edit: Maybe it is lacking a bit of focus. If there isn't an issue for simply omitting trailing types then maybe someone should open one. Might it conflict with type parameter defaults though? |
That was my thinking as well. There is a lot of overlap between each of these proposals, with similar thoughts being shared. I haven't seen any mention to rein this into an MVP. IMO, the current proposals are too broad.
I'm not sure how. At least any more than the current proposals would. Requiring leading types is more restrictive. Default types are also restrictive: function foo<A,B = string,C>(a: A, b: B, c: C) {}
// error on C: Required type parameters may not follow optional type parameters. Do you have something in mind? |
@lukescott I think it's something like: function totoro<A, B = object>(a: A, b: B) { ... } Currently if I call this function thusly: totoro('friend', new Date(2018, 3, 19)) Inside of |
@ohjames function totoro<A, B = object>(a: A, b: B): [A,B] {
return [a,b]
}
const result1 = totoro('friend', new Date(2018, 3, 19))
const result2 = totoro<string>('friend', new Date(2018, 3, 19)) result1 comes back with It would seem like either proposal has the same effect on this. In either case you could either change how it works and infer Personally I would prefer to break compatibility here and use default only when the type can not be inferred. |
@lukescott Thanks for fixing my example. Glad you agree with the compatibility break but not sure if others will see it the same as us. It's been bothering me ever since C# adopted this limitation. Feel like it takes a lot away without bringing anything. |
Can't we support a I have a feeling that My syntax would allow for supplying just the single type parameter that is causing a complete lack of type inference. For example, when calling the below function function f<A, B, C, D>(a : A, b : B, c : C) : D {
...
} I suggest making it possible to call this with the syntax: var d = f<D = string>(1, 2, 3); |
I would also like to be able to omit all inferred types when unambiguous: interface SpecialArray<T> extends Array<T> {}
let a: SpecialArray<_> = [1]
// and
let b: SpecialArray<> = [1]
// are both equivalent to:
let c: SpecialArray<number> = [1]; |
@weswigham Is there anything we can work on to make the study of this proposal easier for the team ? |
It this hold up due to a limitation of the language, the lack of an implementation, or the indecisiveness of the syntax? |
Any update? |
https://github.com/microsoft/TypeScript/wiki/FAQ#any-updates (I'll delete this comment if you delete yours, @tomerh2001 ) |
@jcalz, in a perfect world I'd agree, but many repos have a bot that will auto-close issues after a certain period of inactivity, so developers have been trained to periodically bump issues they care about to ensure they stay open. |
I would like to see the implementation plan or alternative solution for this proposal, which will undoubtedly bring huge benefits to developers. |
I proposed a keyword generic reference, which might solve the problem more elegantly. |
Was grouping generics as sets every discussed, not viable? Single sets behavior would remain unchanged, otherwise opt in. const declare = <V,><D,>(value: V, descriptor: D) => {
return { value, descriptor }
}
declare<number>(12, "Number" as const) // { value: number; descriptor: "Number" } |
@motherthestate, I think the idea looks intriguing at first. You could call this Generic Currying. You can "kind of" achieve that already if you curry the function itself: const declare = <V>(value: V) =>
<D>(descriptor: D) =>
({ value, descriptor })
declare<number>(12)("Number" as const) This works surprisingly well. Is this great? Probably not. But it allows you to get a feel for how this would work. Even if just currying the generics would be a feature, it would have a similar drawback: You would have to know whether the arguments are curried. This would only have the benefit over runtime currying, that it wouldn't need to curry the runtime — which honestly for many cases wouldn't matter that much. The benefit would be rather slim, given the added complexity. |
Would be great to reconsider allowing specifying type parameters by name. Otherwise functions with complex type parameters have exactly the same problem as functions with complex runtime parameters:
We don't encourage writing functions like |
I feel like 3b is a great one, but also that "missing" ones should be filled in with So Basically where A different idea would be to have an const someFunc = <OBJECT, Infer<KEY extends keyof OBJECT>>(...) It that case it wouldn't even accept anything for that position, and skip it entirely. |
After thoughts digestI've been reading, thinking and experimenting quite a bit on this situation now. PurposeMany things have been said, proposals have emerged and it's hard to keep up with what have been deemed impractical or invalid. This aims to offer a walkthrough of a valid, convenient and safe proposal. The requirementBe able to infer type parameters even if the consumer passes some type parameters Walkthroughdeclare function get<Doc, Key extends keyof Doc>(doc: Doc, key: Key): Doc[Key]; We could consider that in the context of a function call, every generic argument is optional. And therefore the following would be valid : declare var obj: unknown;
const value = get<{ title: string }>(obj, 'title'); // string
However, the fact that TS emits an error for the missing type argument is a valuable information and I don't think we should assume the consumer will not forget a type argument they actually want. declare function get<Doc, optional Key extends keyof Doc>(doc: Doc, key: Key): Doc[Key];
const value = get<{ title: string }>(obj, 'title'); // string But wait, I have several question already ! Why not use a default type argument ?declare function get<Doc extends { title: string }, Key extends keyof Doc = 'title'>(doc: Doc, key: Key): Doc[Key];
declare let obj: any;
// ❌ TS2345: Argument of type 'foo' is not assignable to parameter of type 'title'
const value = get<{ title: string; description: string }>(obj, 'foo'); As you can see, using a default type argument set the expected type and therefore the consumer must comply to that default type. So we can't set a default to achieve our goal. What about multiple signatures ?In the current state of TS, the signature is picked based on the consumer call. Is it any different than other suggestions for
|
Since my quick ctrl+f (after expanding the 100+ comments) did not show that this has been suggested before. It would make sense to me to be able to explicitly choose the default type parameter type using the As suggested by someone before, being able to do |
@lazytype what problem does this solve ? It's already possible to have the same behaviour by passing |
@JesusTheHun can you clarify where you're passing One problem
which defensively prevents the user from ever passing an incorrect value for |
@shicks Let's say your type is the following : type Foo<A, B> = { a: A; b: B }; If you want to allow to skip parameter type DefaultA = number;
type Foo<A, B> = {
[A] extends [never] ?
{ a: DefaultA; b: B } :
{ a: A; b: B }
};
type FooSkipA = Foo<never, string>; // { a: number; b: string } Also note that, since the consumers can see the type definition, they can provide the same type as the default. It's just less convenient for them. So, while it's not the perfect solution, your problem is already solvable. EDIT: also note that this is different than what this proposal is about. This proposal is about inference, not default values. |
After exploring the concept in #23696, we've come to the conclusion that implicitly making type arguments available by name would unnecessarily expose previously unobservable implementation details. As such, I'll be breaking that proposal down into two parts. One is just the partial inference (which is here), which can stand on its own, as discussed in #20122 and #10571.
To recap, partial type argument inference is the idea that some number of type arguments in a type argument list may be provided, while others are elided and fulfilled via inference using the rest. Specifically, in #10571 a number of different syntax proposals will brought forward:
For the following examples, assume we have a
Variant 1 - elided entries
This is the most terse option, as simply the lack of inputs implies inference sites. This would almost seem to logically follow from how not providing a list also causes inference to occur at all sites. This does have issues, however: specifying a final parameter as needing inference would require a trailing
,
in the list (something we currently explicitly disallow), and lists could very easily become confusing, as a,
is very easy to skip over.Variant 2 - Sigil marker
As the second most terse option, this also has appeal; however I think it also fails on a few points. First,
*
is non-obvious what it means; it implies a "wildcard" of some kind, but in the context of types that could mean an inferred type, a bound, or an existential. Second, as a single-character sigil, we're unlikely to meaningfully provide completions for it even though it is contextually relevant. Finally, we're considering other work to do with existentials and generated type parameters in the future which we'd like to be able to use the*
as an indicator for.Variant 3 - Keyword marker
a.
auto
b.
infer
Neither of these are as terse as the others, but both are still likely substantially shorter than providing the entire list of types by hand in situations where partial inference is desired. Of the two keywords,
auto
may be shorter, but currently carries no meaning within the language.infer
on the other hand is already used for marking inference positions within conditional types. Theinfer
method was explored in #22368, however was taken much father - almost fully replicating the arbitrary placement and naming the operator affords within conditional types.In the end, I'm advocating for variant 3b - the
infer
placeholder, with none of the extra features afforded in #22368 (we can always add them later if there is demand).The text was updated successfully, but these errors were encountered: