Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typesMapLocation not forwarded from Session to ProjectService #22607

Closed
kyliau opened this issue Mar 15, 2018 · 1 comment
Closed

typesMapLocation not forwarded from Session to ProjectService #22607

kyliau opened this issue Mar 15, 2018 · 1 comment
Assignees
@amcasey
Labels
Bug A bug in TypeScript
Milestone
TypeScript 3.1

Comments

@kyliau
Copy link
Contributor

kyliau commented Mar 15, 2018 •
edited
Loading

TypeScript Version: 2.8.0-dev.20180315

Search Terms:
typesMapLocation

// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.

Bring up tsserver with argument --typesMapLocation /path/to/typesMap.json and turn on logging.
Inspect the logs, and see that Provided types map file "/path/to//typesMap.json" doesn't exist even though the file is valid.

Expected behavior:
typesMap.json should be correctly located and error not shown in logs.

Actual behavior:
Error message about non-existent typeMaps.json shown in the logs.

Playground Link:

Related Issues:
kyliau pushed a commit to kyliau/TypeScript that referenced this issue Mar 15, 2018
Forward typesMapLocation from Session from ProjectService (microsoft#…
78f588d 
…22607)

When a new ProjectService is created from a new Session, the
typesMapLocation of the typingsInstaller is not forwarded to the the
ProjectService, and results in the error message
`Provided types map file "/path/to/typesMap.json" doesn't exist`
@kyliau kyliau mentioned this issue Mar 15, 2018
Closed
@sheetalkamat sheetalkamat mentioned this issue Mar 15, 2018
Merged
@RyanCavanaugh RyanCavanaugh self-assigned this Mar 15, 2018
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Mar 15, 2018
amcasey added a commit to amcasey/TypeScript that referenced this issue Mar 21, 2018
@amcasey
Thread typesMapLocation down to the ProjectService
2e0f325 
Fixes microsoft#22607
@amcasey amcasey mentioned this issue Mar 21, 2018
Merged
@mhegazy mhegazy added this to the TypeScript 2.9 milestone Mar 29, 2018
@sheetalkamat sheetalkamat assigned amcasey and unassigned sheetalkamat Sep 17, 2018
@sheetalkamat
Copy link
Member

Assigned to @amcasey since there is already PR #22776 for this that I just re-opened.

amcasey added a commit to amcasey/TypeScript that referenced this issue Sep 18, 2018
@amcasey
Thread typesMapLocation down to the ProjectService
1bcb491 
Fixes microsoft#22607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcasey amcasey

Labels
Bug A bug in TypeScript
Projects
None yet
Milestone
TypeScript 3.1
Development

No branches or pull requests
5 participants
@kyliau @RyanCavanaugh @mhegazy @sheetalkamat @amcasey