Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigFileDiagnosticEvent fires for files not selected by tsconfig #16635

Closed
krisselden opened this issue Jun 20, 2017 · 0 comments
Closed

ConfigFileDiagnosticEvent fires for files not selected by tsconfig #16635

krisselden opened this issue Jun 20, 2017 · 0 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@krisselden
Copy link

krisselden commented Jun 20, 2017

TypeScript Version: 2.4.0 / nightly (2.5.0-dev.201xxxxx)

Code

Reproduction:
https://github.com/krisselden/tsserver-config-file-diag-issue

Basically if a tsconfig.json uses a include/exclude instead of files to select input, tsserver will notify any change to a ts file in or below the directory containing the tsconfig even if not matched as input.

Expected behavior:
Don't fire the event for ts files that don't belong to the tsconfig.json file.

Actual behavior:
Any file ts file change emits this event.

This issue came to light due to a recent change in VS Code 1.13.0 which always opens the triggerFile for this event, causing the tsserver to create an implicit project for it since it doesn't belong to the actual project. Due to our build system staging files in tmp/ this causes tsserver to open a lot of files with the implicit project.

microsoft/vscode@0d5c9f4

@krisselden krisselden changed the title ConfigFileDiagnosticEvent fires files not selected by tsconfig ConfigFileDiagnosticEvent fires for files not selected by tsconfig Jun 20, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label Aug 23, 2017
@mhegazy mhegazy added this to the TypeScript 2.6 milestone Aug 23, 2017
sheetalkamat added a commit that referenced this issue Oct 4, 2017
…red project and that project doesnt have the config errors

Fixes #16635
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Oct 4, 2017
@mhegazy mhegazy closed this as completed Oct 4, 2017
sheetalkamat added a commit that referenced this issue Oct 4, 2017
…red project and that project doesnt have the config errors

Fixes #16635
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants