Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow omitting '/**/*' in include #10578

Closed
DanielRosenwasser opened this issue Aug 28, 2016 · 4 comments
Closed

Allow omitting '/**/*' in include #10578

DanielRosenwasser opened this issue Aug 28, 2016 · 4 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Aug 28, 2016

This is a huge time sink for users who are going to think

"include": ["./foo/bar"]

is equivalent to

"include": ["./foo/bar/**/*"]

At the very least, we can give a warning.

Of note, "exclude": "./foo" seems to be equivalent to "exclude": "./foo/**/*, so why is there an inconsistency here?

@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Aug 28, 2016
@mhegazy mhegazy added this to the TypeScript 2.1 milestone Aug 28, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Aug 28, 2016

@riknoll can you take a look.

DanielRosenwasser added a commit to microsoft/TypeScript-Handbook that referenced this issue Sep 27, 2016
@mhegazy mhegazy modified the milestones: Future, TypeScript 2.1 Sep 29, 2016
@mhegazy mhegazy assigned ghost and unassigned riknoll Sep 29, 2016
@cdaringe
Copy link

cdaringe commented Oct 6, 2016

the docs, as mentioned in #11425, already declare that this is how it works. FYI!

@basarat
Copy link
Contributor

basarat commented Oct 6, 2016

I have a section for it in TypeScript deep dive as well : https://basarat.gitbooks.io/typescript/content/docs/project/files.html 🌹

@mhegazy
Copy link
Contributor

mhegazy commented Oct 6, 2016

ppl keep running into this issue. we need to fix this sooner.

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Oct 24, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.1, TypeScript 2.1.2 Oct 27, 2016
@ghost ghost closed this as completed in #11495 Oct 31, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

5 participants