Fix noImplicitAny check on ambient private getters (#33896)

microsoft · Oct 9, 2019 · e48cd3a · e48cd3a
1 parent 3d130b7
commit e48cd3a
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 1 deletion.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -7436,7 +7436,9 @@ namespace ts {
                         }
                         else {
                             Debug.assert(!!getter, "there must exist a getter as we are current checking either setter or getter in this function");
-                            errorOrSuggestion(noImplicitAny, getter!, Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            if (!isPrivateWithinAmbient(getter!)) {
+                                errorOrSuggestion(noImplicitAny, getter!, Diagnostics.Property_0_implicitly_has_type_any_because_its_get_accessor_lacks_a_return_type_annotation, symbolToString(symbol));
+                            }
                         }
                         return anyType;
                     }

diff --git a/tests/baselines/reference/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.js b/tests/baselines/reference/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.js
@@ -5,6 +5,8 @@ declare class Something
 {
     private static someStaticVar;
     private someVar;
+    private get getter();
+    private set setter(v);
 }
 
 //// [app.ts]

diff --git a/tests/baselines/reference/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.symbols b/tests/baselines/reference/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.symbols
@@ -13,5 +13,12 @@ declare class Something
 
     private someVar;
 >someVar : Symbol(Something.someVar, Decl(test.d.ts, 2, 33))
+
+    private get getter();
+>getter : Symbol(Something.getter, Decl(test.d.ts, 3, 20))
+
+    private set setter(v);
+>setter : Symbol(Something.setter, Decl(test.d.ts, 4, 25))
+>v : Symbol(v, Decl(test.d.ts, 5, 23))
 }
 
diff --git a/tests/baselines/reference/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.types b/tests/baselines/reference/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.types
@@ -14,5 +14,12 @@ declare class Something
 
     private someVar;
 >someVar : any
+
+    private get getter();
+>getter : any
+
+    private set setter(v);
+>setter : any
+>v : any
 }
 
diff --git a/tests/cases/compiler/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.ts b/tests/cases/compiler/noImplicitAnyAndPrivateMembersWithoutTypeAnnotations.ts
@@ -3,6 +3,8 @@ declare class Something
 {
     private static someStaticVar;
     private someVar;
+    private get getter();
+    private set setter(v);
 }
 
 // @noimplicitany: true