Skip to content

Commit

Permalink
🤖 Pick PR #54588 (Fixed a regression with string comp...) into releas…
Browse files Browse the repository at this point in the history
…e-5.1 (#54635)

Co-authored-by: Mateusz BurzyÅ„ski <[email protected]>
  • Loading branch information
TypeScript Bot and Andarist authored Jun 26, 2023
1 parent 2faa176 commit db3575a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/services/stringCompletions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL
// Get string literal completions from specialized signatures of the target
// i.e. declare function f(a: 'A');
// f("/*completion position*/")
return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType();
return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType(ContextFlags.None);
}
// falls through (is `require("")` or `require(""` or `import("")`)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/// <reference path="fourslash.ts" />
// @strict: true
////
//// function fn<T extends ('value1' | 'value2' | 'value3')[]>(...values: T): T { return values; }
////
//// const value1 = fn('/*1*/');
//// const value2 = fn('value1', '/*2*/');

verify.completions({ marker: ["1", "2"], includes: [`value1`, `value2`, `value3`] })

0 comments on commit db3575a

Please sign in to comment.