add diagnostics messages 'Method not implemented.' and 'Function not …

…implemented.'
microsoft · Dec 19, 2020 · 127e16e · 127e16e
1 parent d6d18ea
commit 127e16e
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 4 deletions.
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -5991,6 +5991,14 @@
         "category": "Message",
         "code": 95150
     },
+    "Method not implemented.": {
+        "category": "Message",
+        "code": 95151
+    },
+    "Function not implemented.": {
+        "category": "Message",
+        "code": 95152
+    },
 
 
     "No value exists in scope for the shorthand property '{0}'. Either declare one or provide an initializer.": {

diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
@@ -285,10 +285,29 @@ namespace ts.codefix {
             : checker.typeToTypeNode(contextualType, contextNode, /*flags*/ undefined, tracker);
 
         if (kind === SyntaxKind.MethodDeclaration) {
-            const body = isInterfaceDeclaration(contextNode) ? undefined : createStubbedMethodBody(quotePreference);
-            return factory.createMethodDeclaration(/*decorators*/ undefined, modifiers, asteriskToken, name, /*questionToken*/ undefined, typeParameters, parameters, type, body) as T;
+            return factory.createMethodDeclaration(
+                /*decorators*/ undefined,
+                modifiers,
+                asteriskToken,
+                name,
+                /*questionToken*/ undefined,
+                typeParameters,
+                parameters,
+                type,
+                isInterfaceDeclaration(contextNode) ? undefined : createStubbedMethodBody(quotePreference)
+            ) as T;
         }
-        return factory.createFunctionDeclaration(/*decorators*/ undefined, modifiers, asteriskToken, name, typeParameters, parameters, type, createStubbedBody("Function not implemented.", quotePreference)) as T;
+
+        return factory.createFunctionDeclaration(
+            /*decorators*/ undefined,
+            modifiers,
+            asteriskToken,
+            name,
+            typeParameters,
+            parameters,
+            type,
+            createStubbedBody(Diagnostics.Function_not_implemented.message, quotePreference)
+        ) as T;
     }
 
     export function typeToAutoImportableTypeNode(checker: TypeChecker, importAdder: ImportAdder, type: Type, contextNode: Node | undefined, scriptTarget: ScriptTarget, flags?: NodeBuilderFlags, tracker?: SymbolTracker): TypeNode | undefined {
@@ -392,7 +411,7 @@ namespace ts.codefix {
     }
 
     function createStubbedMethodBody(quotePreference: QuotePreference) {
-        return createStubbedBody("Method not implemented.", quotePreference);
+        return createStubbedBody(Diagnostics.Method_not_implemented.message, quotePreference);
     }
 
     export function createStubbedBody(text: string, quotePreference: QuotePreference): Block {