Handle abstract and const modifiers

microsoft · Nov 9, 2016 · 0208345 · 0208345
1 parent 06331b5
commit 0208345
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 5 deletions.
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -870,11 +870,12 @@ namespace ts {
                                 diagnostics.push(createDiagnosticForNodeArray(nodes, Diagnostics.type_parameter_declarations_can_only_be_used_in_a_ts_file));
                                 return;
                             }
-                        // pass through
+                            // pass through
+                            let isConstValid = false;
                         case SyntaxKind.VariableStatement:
                             // Check modifiers
                             if (nodes === (<ClassDeclaration | FunctionLikeDeclaration | VariableStatement>parent).modifiers) {
-                                return checkModifiers(<NodeArray<Modifier>>nodes);
+                                return checkModifiers(<NodeArray<Modifier>>nodes, isConstValid);
                             }
                             break;
                         case SyntaxKind.PropertyDeclaration:
@@ -911,23 +912,27 @@ namespace ts {
                     }
                 }
 
-                function checkModifiers(modifiers: NodeArray<Modifier>) {
+                function checkModifiers(modifiers: NodeArray<Modifier>, isConstValid: boolean) {
                     for (const modifier of modifiers) {
                         switch (modifier.kind) {
+                            case SyntaxKind.ConstKeyword:
+                                if (isConstValid) {
+                                    continue;
+                                }
+                                //Fallthrough to report error
                             case SyntaxKind.PublicKeyword:
                             case SyntaxKind.PrivateKeyword:
                             case SyntaxKind.ProtectedKeyword:
                             case SyntaxKind.ReadonlyKeyword:
                             case SyntaxKind.DeclareKeyword:
+                            case SyntaxKind.AbstractKeyword:
                                 diagnostics.push(createDiagnosticForNode(modifier, Diagnostics._0_can_only_be_used_in_a_ts_file, tokenToString(modifier.kind)));
                                 break;
 
                             // These are all legal modifiers.
                             case SyntaxKind.StaticKeyword:
                             case SyntaxKind.ExportKeyword:
-                            case SyntaxKind.ConstKeyword:
                             case SyntaxKind.DefaultKeyword:
-                            case SyntaxKind.AbstractKeyword:
                         }
                     }
                 }

diff --git a/tests/baselines/reference/jsFileCompilationAbstractModifier.errors.txt b/tests/baselines/reference/jsFileCompilationAbstractModifier.errors.txt
@@ -0,0 +1,14 @@
+error TS5055: Cannot write file 'tests/cases/compiler/a.js' because it would overwrite input file.
+tests/cases/compiler/a.js(1,1): error TS8009: 'abstract' can only be used in a .ts file.
+tests/cases/compiler/a.js(2,5): error TS8009: 'abstract' can only be used in a .ts file.
+
+
+!!! error TS5055: Cannot write file 'tests/cases/compiler/a.js' because it would overwrite input file.
+==== tests/cases/compiler/a.js (2 errors) ====
+    abstract class c {
+    ~~~~~~~~
+!!! error TS8009: 'abstract' can only be used in a .ts file.
+        abstract x;
+        ~~~~~~~~
+!!! error TS8009: 'abstract' can only be used in a .ts file.
+    }
diff --git a/tests/baselines/reference/jsFileCompilationConstModifier.symbols b/tests/baselines/reference/jsFileCompilationConstModifier.symbols
@@ -0,0 +1,4 @@
+=== tests/cases/compiler/a.js ===
+const c = 10;
+>c : Symbol(c, Decl(a.js, 0, 5))
+
diff --git a/tests/baselines/reference/jsFileCompilationConstModifier.types b/tests/baselines/reference/jsFileCompilationConstModifier.types
@@ -0,0 +1,5 @@
+=== tests/cases/compiler/a.js ===
+const c = 10;
+>c : 10
+>10 : 10
+
diff --git a/tests/cases/compiler/jsFileCompilationAbstractModifier.ts b/tests/cases/compiler/jsFileCompilationAbstractModifier.ts
@@ -0,0 +1,5 @@
+// @allowJs: true
+// @filename: a.js
+abstract class c {
+    abstract x;
+}
diff --git a/tests/cases/compiler/jsFileCompilationConstModifier.ts b/tests/cases/compiler/jsFileCompilationConstModifier.ts
@@ -0,0 +1,4 @@
+// @allowJs: true
+// @filename: a.js
+// @noEmit: true
+const c = 10;