Add context about when to use type predicates and assertion functions #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Updated based on discussion in #57436
|
"supersede" doesn't seem like the right term to me; "bypass" or "override" seem more accurate. |
|
@jakebailey great suggestion. I wasn't thrilled with "supersede" but wasn't coming up with a better term. I think "bypass" does a much better job conveying the behavior. |
Updated based on feedback from Jake Bailey
Masstronaut
changed the title
|
@jakebailey anything else I need to do here? It's my first time contributing to the TS docs so I'm blissfully unaware of any other process/requirements to get this PR merged in. |
|
See #2804, we don't have much bandwidth to review all but critical changes. I wouldn't want to merge this without someone like @RyanCavanaugh or @DanielRosenwasser giving it a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated based on discussion in #57436