Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve broken link to preserveConstEnums #1104

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Sep 17, 2020

Description

Tags

Found while writing #1103

Review Notes

Not sure if that's the best link per description, but unsure which it should link to

- spec.md was renamed to spec-ARCHIVED.md in the TypeScript repo, so
  link started 404'ing
  - as it's now archived, perhaps this should point somewhere else?
    e.g. the const enums section in the Enums doc in the Handbook or
    the preserveConstEnums description in the TSConfig Reference?
    - they both have different text than the spec, so unsure
@orta orta merged commit e7cfc04 into microsoft:v2 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants