Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Revert "Update Compiler Options.md" #816

Conversation

NMinhNguyen
Copy link
Contributor

This reverts commit 8e974c8.

This supports microsoft/TypeScript#26866, and thus should not be merged before the code change itself.

I wasn't sure if I'm targeting the right branch with this PR (I couldn't find branch release-3.1 which I believe @RyanCavanaugh would like the code change to go into), so please let me know if I should change it.

Fixes microsoft/TypeScript#26193.

/cc @DanielRosenwasser

@BurtHarris
Copy link

@NMinhNguyen, I'm not sure the documentation is useful either way. Would it be correct to document -- allowSyntheticDefaultImports as deprecated, and say that --esModuleInterop is a more comprehensive solution to the problem synthetic default imports was trying to address?

@RyanCavanaugh RyanCavanaugh merged commit 3c72341 into microsoft:master Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants