Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event handlers for gamepadconnected GamepadEvent #925

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

elyseyao
Copy link
Contributor

@elyseyao elyseyao commented Oct 2, 2020

Added event handlers ongamepadconnected and ongamepaddisconnected to add their corresponding events to lib.dom.d.ts and resolve this issue. The event handler names were taken from MDN.

@elyseyao elyseyao requested a review from sandersn as a code owner October 2, 2020 00:56
@saschanaz
Copy link
Contributor

saschanaz commented Oct 2, 2020

This is not the right way to add them, as the spec does not define ongamepadconnected/ongamepaddisconnected. We need to file a spec issue first. (Edit: Filed w3c/gamepad#141)

Currently the alternative way is to use attributeless-events instead of general events.

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is widely supported and the spec change hasn't happened yet. Let's take this now and remove the addedTypes override when the spec change gets merged.

@sandersn sandersn merged commit 33d8144 into microsoft:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib.dom.d.ts window interfaces missing "gamepadconnected" and "gamepaddisconnected"
3 participants