Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderingContext.uniform[1234][fv]() accepts ArrayLike<number> #592

Closed
wants to merge 1 commit into from
Closed

WebGLRenderingContext.uniform[1234][fv]() accepts ArrayLike<number> #592

wants to merge 1 commit into from

Conversation

Istar-Eldritch
Copy link

@msftclas
Copy link

msftclas commented Oct 29, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@saschanaz
Copy link
Contributor

I'm not sure MDN says ArrayLike is allowed. Float32List is defined as:

typedef ([AllowShared] Float32Array or sequence<GLfloat>) Float32List;

It does allow sequences, but sequences require Symbol.iterator support. ArrayLike in TypeScript is invalid because it does not include Symbol.iterator.

@saschanaz saschanaz mentioned this pull request Oct 30, 2018
Closed
@orta
Copy link
Contributor

orta commented Feb 25, 2020

Thanks for the PR! This looks like it was superseded #699

@orta orta closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Istar-Eldritch @msftclas @saschanaz @orta