Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lightgbm to 2.2.400, fix probabilities and some windows errors #676

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

imatiach-msft
Copy link
Contributor

update lightgbm to 2.2.400 - recently uploaded maven artifact of latest lightgbm build
includes fixes:
1.) Fix lightgbm swig wrapper on windows - now most windows tests will pass. Not re-enabling windows tests yet because I am still seeing a test failure,but the majority of tests seem to pass now.
microsoft/LightGBM#2364
2.) fix cached predictor causing bad probability values
microsoft/LightGBM#2356
3.) exponential backoff for MPI ring connection, should improve test times significantly
microsoft/LightGBM#2354

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #676 into master will decrease coverage by 21.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #676       +/-   ##
===========================================
- Coverage   79.09%   58.06%   -21.04%     
===========================================
  Files         226      173       -53     
  Lines        9014     7840     -1174     
  Branches      490      496        +6     
===========================================
- Hits         7130     4552     -2578     
- Misses       1884     3288     +1404
Impacted Files Coverage Δ
.../microsoft/ml/spark/lightgbm/LightGBMBooster.scala 82.89% <100%> (-15.81%) ⬇️
...a/com/microsoft/ml/spark/lightgbm/TrainUtils.scala 64.57% <100%> (-22.6%) ⬇️
...om/microsoft/ml/spark/lightgbm/LightGBMUtils.scala 94.73% <100%> (-0.56%) ⬇️
...cala/com/microsoft/ml/spark/io/binary/Binary.scala 0% <0%> (-100%) ⬇️
...ql/execution/streaming/continuous/HTTPSinkV2.scala 0% <0%> (-96.56%) ⬇️
.../execution/streaming/continuous/HTTPSourceV2.scala 0% <0%> (-93.05%) ⬇️
...oft/ml/spark/recommendation/RankingEvaluator.scala 0% <0%> (-92.31%) ⬇️
...osoft/ml/spark/io/http/PartitionConsolidator.scala 4.44% <0%> (-88.89%) ⬇️
...che/spark/sql/execution/streaming/HTTPSource.scala 0% <0%> (-87.81%) ⬇️
...ql/execution/streaming/DistributedHTTPSource.scala 0% <0%> (-84.36%) ⬇️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ea090...6c7a592. Read the comment docs.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants