Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed port and added example #352

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

inchiosa
Copy link
Contributor

  1. Changed port from 8888 to 8898 to not conflict with Jupyter port.
  2. Removed label column from test example
  3. Added a second test example that produces a response of 1.0
  4. Leaving output cells in notebook, so folks can see what the notebook is supposed to produce.

@mhamilton723
Copy link
Collaborator

Thanks a ton for adding this @inchiosa. DO you think you could remove the notbook output for consistency's sake. The general idea of keeping notbook ouputs for legibility is a good one, but we will need to do a bit of refactoring work to make this work for all notebooks. If you need I can do that before the merge as well!

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (04292423)

MMLSpark 0.13.dev19+2.g0429242

This is a build for Github PR #352, changes:


@mhamilton723 mhamilton723 merged commit bdf354f into microsoft:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants