feat: Enable GPT-4 in OpenAIPrompt #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Microsoft" |
sss04
commented
Jul 9, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
sss04
commented
Jul 9, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
added 2 commits
July 10, 2024 11:01
sss04
commented
Jul 10, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
cognitive/src/test/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPromptSuite.scala
Show resolved
Hide resolved
mhamilton723
requested changes
Jul 10, 2024
…es/openai/OpenAIPrompt.scala Update default system prompt Co-authored-by: Mark Hamilton <[email protected]>
…es/openai/OpenAIPrompt.scala remove unneeded comment Co-authored-by: Mark Hamilton <[email protected]>
…es/openai/OpenAIPrompt.scala remove unneeded comment Co-authored-by: Mark Hamilton <[email protected]>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2248 in repo microsoft/SynapseML |
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
|
/azp run |
mhamilton723
previously approved these changes
Jul 11, 2024
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2248 +/- ##
==========================================
- Coverage 86.05% 82.25% -3.80%
==========================================
Files 327 327
Lines 16742 16773 +31
Branches 1509 1511 +2
==========================================
- Hits 14407 13797 -610
- Misses 2335 2976 +641 ☔ View full report in Codecov by Sentry. |
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2248 in repo microsoft/SynapseML |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
None.
What changes are proposed in this pull request?
Enabling use of GPT-4 in OpenAIPrompt by using OpenAIChatCompletions within it. This change switches to OpenAIChatCompletion if using gpt-4, and uses OpenAICompletion for all other models.
How is this patch tested?
The currently existing tests for OpenAIPrompt in OpenAIPromptSuite were duplicated to ensure that they also worked for gpt-4.
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.