Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Platform Detection Logic on Fabric #2234

Merged
merged 2 commits into from
Jun 15, 2024
Merged

fix: Fix Platform Detection Logic on Fabric #2234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae32b0
fix platform detection logic
mslhrotk Jun 12, 2024
7b4e370
Merge branch 'master' into cl/fix-platform-detection
mhamilton723 Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/scala/com/microsoft/azure/synapse/ml/logging/common/PlatformDetails.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,13 @@ object PlatformDetails {
def currentPlatform(): String = {
val azureService = sys.env.get("AZURE_SERVICE")
azureService match {
case _ if new java.io.File("/home/trusted-service-user/.trident-context").exists() => PlatformSynapseInternal
// Note Below judgement doesn't work if you are not in main thread
// In Fabric, existence of above file should always gives right judgement
// In Synapse, hitting below condition has risks.
case Some(serviceName) if serviceName == SynapseProjectName =>
defineSynapsePlatform()
case _ if new java.io.File("/dbfs").exists() => PlatformDatabricks
case _ if new java.io.File("/home/trusted-service-user/.trident-context").exists() => PlatformSynapseInternal
case _ if sys.env.contains("BINDER_LAUNCH_HOST") => PlatformBinder
case _ => PlatformUnknown
}
Expand Down
Loading