Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update find_secret on Fabric and doc #2132

Merged
merged 15 commits into from
Nov 27, 2023

Conversation

JessicaXYWang
Copy link
Contributor

@JessicaXYWang JessicaXYWang commented Nov 13, 2023

Add find_secret doc for ADB and Synapse Analytics.

work item to Fang's team: https://msdata.visualstudio.com/A365/_workitems/edit/2824561

Copy link

Hey @JessicaXYWang 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3ae146) 86.19% compared to head (469ca36) 85.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2132      +/-   ##
==========================================
- Coverage   86.19%   85.32%   -0.87%     
==========================================
  Files         312      312              
  Lines       16483    16483              
  Branches     1462     1462              
==========================================
- Hits        14207    14064     -143     
- Misses       2276     2419     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang JessicaXYWang changed the title docs: add find secret doc for synapse and adb fix: update find_secret on Fabric and doc Nov 20, 2023
@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JessicaXYWang
Copy link
Contributor Author

@mhamilton723 please help to review. Dev team confirmed there won't be update for getSecret. It is by design. We should make change on our side.

@mhamilton723 mhamilton723 merged commit 2a01c8e into microsoft:master Nov 27, 2023
6 checks passed
@JessicaXYWang JessicaXYWang deleted the addFindSecretDoc branch December 9, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants