-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove secret scanner #2048
chore: remove secret scanner #2048
Conversation
/azp run |
Hey @mhamilton723 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary by GPT-4
The code removed in this commit is a test called "Scan codebase for secrets". This test scans the codebase for any secrets (like passwords, API keys, etc.) that should not be present in the code. It does this by checking file names and contents against a list of regular expressions that match common secret patterns.
The test first excludes certain files and directories from the scan, such as images and build artifacts. Then, it reads the list of regular expressions from a file specified by Secrets.SecretRegexpFile
. For each file in the codebase, it checks if its name or any of its lines match any of the regular expressions. If there are any matches, the test fails and reports the issues found.
By removing this test, the codebase will no longer be checked for secrets during testing. This could potentially lead to sensitive information being accidentally committed to the repository.
Suggestions
No suggestions are needed as the changes in this PR seem to be clear and straightforward.
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
- Coverage 87.05% 86.99% -0.06%
==========================================
Files 306 306
Lines 16063 16063
Branches 852 852
==========================================
- Hits 13983 13974 -9
- Misses 2080 2089 +9 |
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.