-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve LGBM exception and logging #2037
Conversation
Hey @svotaw 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary by GPT-4
The changes in this commit include:
-
In
NetworkManager.scala
, the log message for "received nodes for network init" has been moved after the log message for "received partition topology". This change makes the log messages appear in a more logical order. -
A new log message has been added in
parseExecutorPartitionList
function to show the partitions received by each executor. -
In
StreamingPartitionTask.scala
, some log messages have been changed from info level to debug level, as they might be too verbose for normal operation. These messages include "Inserting rows into training Dataset" and "Pushing dense/sparse rows". -
Some unnecessary log messages have been removed, such as "Adjusting initial scores", "Pushing sparse rows", and "LightGBM pushed startIndex in partition".
Overall, these changes improve the readability and usefulness of the log messages generated by LightGBM during training.
Suggestions
No suggestions are needed as the changes in this PR seem appropriate.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2037 +/- ##
==========================================
- Coverage 87.09% 85.72% -1.37%
==========================================
Files 306 306
Lines 16068 16063 -5
Branches 860 852 -8
==========================================
- Hits 13994 13770 -224
- Misses 2074 2293 +219
|
* Improve LGBM exception and logging * added log
Fix a bug in exception handling and improve logs for LightGBM