Skip to content

Commit

Permalink
Removing binary dependencies for telemetry (#202)
Browse files Browse the repository at this point in the history
This reverse engineers the REST API for Application Insights so that
we no longer need to download / depend on the 3 .dll files that were
necessary to use the Application Insights .NET SDK.

This is directly benefitting from the work that was done for
PowerShellForGitHub (see microsoft/PowerShellForGitHub#186)

> This is a re-implementation of the similar change done in the master
> branch (for v1).  See #201
  • Loading branch information
HowardWolosky authored Aug 23, 2020
1 parent 6ebb0bd commit 322d182
Show file tree
Hide file tree
Showing 2 changed files with 250 additions and 380 deletions.
6 changes: 0 additions & 6 deletions Documentation/SETUP.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,6 @@ StoreBroker has a dependency on dll's from the following NuGet packages:
WindowsAzure.Storage v8.1.1: Microsoft.WindowsAzure.Storage.dll
Microsoft.Azure.Storage.DataMovement v0.5.1: Microsoft.WindowsAzure.Storage.DataMovement.dll

**For [Telemetry](USAGE.md#telemetry)**

Microsoft.ApplicationInsights v2.0.1: Microsoft.ApplicationInsights.dll"
Microsoft.Diagnostics.Tracing.EventSource.Redist v1.1.24: Microsoft.Diagnostics.Tracing.EventSource.dll
Microsoft.Bcl.Async v1.0.168.0: Microsoft.Threading.Tasks.dll

During execution of a command, when StoreBroker has need for an object from one of these dll's,
if it cannot find the dll, it will automatically download nuget.exe, then download the nuget
package that the assembly is in, and finally cache it for the duration of your PowerShell session.
Expand Down
Loading

0 comments on commit 322d182

Please sign in to comment.