Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix truncation warnings in allocate_shared() #4252

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix truncation warnings in allocate_shared() #4252

merged 1 commit into from
Dec 14, 2023

Commits on Dec 10, 2023

  1. Product fix: Truncation warnings in allocate_shared() 

    std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared_for_overwrite.pass.cpp

memory(2858): warning C4267: 'argument': conversion from 'size_t' to 'test_allocator<U>::size_type', possible loss of data

We need to `_Convert_size` when allocating, but if that succeeds, we can simply `static_cast` when deallocating.
    @StephanTLavavej
    StephanTLavavej committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    87c7018 View commit details
    Browse the repository at this point in the history