-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add specialization for 24MHz QueryPerformanceFrequency #3832
Conversation
Co-authored-by: Steven Noonan <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do the push_macro/undef/pop_macro
magic incantation here for likely
and unlikely
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely
and unlikely
are commonly defined as function-like macros, but not object-like macros. <xkeycheck.h>
avoids rejecting them for that reason.
Unlike msvc
etc., users are technically not supposed to macroize likely
and unlikely
, so we technically don't need to defend against them. We could but I don't think it's necessary at the moment.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for implementing this performance improvement! 🚀 🐇 🐆 |
Fixes #3828
Fixes partially #3834
If I do
then
clang-format
format the code this way:A repro that the MSVC compiler simplfying the integer divisions into shifts and multiplies: https://godbolt.org/z/zb5fob6xc