Fix locale test for older OSes #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Aug 28, 2020
|
No problem - locales are a notorious weak point for me, so I learned a little while investigating this. |
barcharcraz
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #1168,
Dev11_0836436_get_timebegan failing in our Microsoft-internal test harness, but only for individual developer test runs (instead of PR/CI test runs, which is how this got through checkin validation). We tracked it down to variation in the OS versions of our test machines. This GitHub repo uses an Azure Virtual Machine Scale Set with Windows Server 2019 Datacenter:STL/azure-devops/create-vmss.ps1
Line 25 in c74ab69
However, some of our internal test machines use Windows Server 2016, which doesn't support UTF-8 locales. Because this test uses only wide strings, we don't actually care about the locale's codepage for narrow strings, so the fix is to remove
".utf-8". Additionally, we were spelling the Russian locale as"ru_RU"and the German locale as"de_DE". There appears to be OS variation here too - the older OS doesn't like the underscores. Spelling the locales with dashes, as we were already doing for"zh-CN", allows the test to pass.There are no other changes besides clang-format rewrapping.