Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encouraging Contributors to Code Review #1097

Closed
mnatsuhara opened this issue Jul 27, 2020 · 2 comments · Fixed by #2212
Closed

Encouraging Contributors to Code Review #1097

mnatsuhara opened this issue Jul 27, 2020 · 2 comments · Fixed by #2212
Labels
documentation Related to documentation or comments fixed Something works now, yay!

Comments

@mnatsuhara
Copy link
Contributor

It can sometimes take time for maintainers to review a PR, and if a PR goes through several iterations of maintainer review, the lifetime of the PR is extended even further. If contributors are willing to review PRs, it can oftentimes accelerate the review process as it allows the PR to be in a more finished state before maintainers review, and fewer maintainer review iterations are needed. It has always been appreciated when contributors are willing to review each others' PRs, but this has not been explicitly said anywhere.

We should make this clear on the wiki or in the README so contributors may be more comfortable reviewing open PRs.
@mnatsuhara mnatsuhara added the documentation Related to documentation or comments label Jul 27, 2020
@MahmoudGSaleh MahmoudGSaleh mentioned this issue Jul 28, 2020
Closed
@MahmoudGSaleh MahmoudGSaleh mentioned this issue Nov 11, 2020
Closed
@KishkinJ10
Copy link

sir can I work on this?? I am a beginner.

KishkinJ10 added a commit to KishkinJ10/STL that referenced this issue May 1, 2021
@KishkinJ10
Fixed issue microsoft#1097
87e0468
@KishkinJ10
Copy link

Sir I have made a PR on this . I am a beginner sir Please check it.

@AlexGuteniev AlexGuteniev mentioned this issue Sep 19, 2021
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Related to documentation or comments fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encouraging Contributors AlexGuteniev/STL
3 participants
@StephanTLavavej @mnatsuhara @KishkinJ10