Skip to content

Commit

Permalink
Status Chart: Modernize modules, chart.js 4.4.2 (#4460)
Browse files Browse the repository at this point in the history
  • Loading branch information
StephanTLavavej authored Mar 16, 2024
1 parent ca163b7 commit 7e8b4af
Show file tree
Hide file tree
Showing 14 changed files with 178 additions and 199 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/compile-typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ jobs:
- name: Install Packages
run: |
npm ci
- name: Compile gather_stats.ts
- name: Compile gather_stats.mts
run: |
npx tsc --noEmit -p src_gather/tsconfig.json
- name: Compile status_chart.ts
- name: Compile status_chart.mts
run: |
npx tsc -p src/tsconfig.json
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
.vscode/

# Ignore the TypeScript compiler's output.
/built/gather_stats.js
/built/gather_stats.mjs

# Ignore installed packages.
/node_modules/
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,22 +77,22 @@ it'll update `package.json` and `package-lock.json` accordingly. `git add` and `
as `dependencies` in `package.json` (e.g. `@octokit/graphql@latest dotenv@latest`).
+ Ensure that the `importmap` in `index.html` remains synchronized to the same versions.
* Update other dependencies in `index.html` (e.g. Primer CSS).
* Update `weekly_table.ts` by adding a new row.
* Update `weekly_table.mts` by adding a new row.
+ We update it every Friday, although nothing bad will happen if we skip a week or update it on a different day.
+ `vso` is the number of Active work items under the STL's Area Path.
+ `libcxx` is the number of skipped/failing tests in `tests/libcxx/expected_results.txt`, excluding
"Missing STL Features" and ignoring configurations (plain/ASAN/Clang). To determine this number, run:
```
python tools/count_libcxx.py STL_REPO/tests/libcxx/expected_results.txt
```
* Run `npm run gather` to compile `gather_stats.ts` and then regenerate `daily_table.ts` and `monthly_table.ts`.
* Run `npm run gather` to compile `gather_stats.mts` and then regenerate `daily_table.mts` and `monthly_table.mts`.
+ This regenerates the files from scratch, but the diff should be small because the data is stable and the process
is deterministic.
+ It's possible for previous values to change, e.g. if an issue is relabeled, but dramatic changes without
corresponding generator changes should be investigated.
+ Automated updates (controlled by `.github/workflows/update-status-chart.yml` in the main repo)
will regenerate these files, so you generally don't need to manually update them in PRs.
* Run `npm run make` to compile `status_chart.ts` and then bundle it and the tables into `built/status_chart.mjs`.
* Run `npm run make` to compile `status_chart.mts` and then bundle it and the tables into `built/status_chart.mjs`.
+ Automated updates will also regenerate this file. However, you'll need to manually update
`built/status_chart.mjs` if you're making synchronized changes to `index.html`.
* Run `npm run view` to preview your changes locally.
Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<script type="importmap">
{ "imports": {
"@kurkle/color": "https://cdn.jsdelivr.net/npm/@kurkle/[email protected]/dist/color.esm.min.js",
"chart.js": "https://cdn.jsdelivr.net/npm/[email protected].1/dist/chart.min.js",
"chart.js": "https://cdn.jsdelivr.net/npm/[email protected].2/dist/chart.min.js",
"chartjs-adapter-luxon": "https://cdn.jsdelivr.net/npm/[email protected]/dist/chartjs-adapter-luxon.esm.min.js",
"luxon": "https://cdn.jsdelivr.net/npm/[email protected]/build/es6/luxon.min.js"
} }
Expand Down
Loading

0 comments on commit 7e8b4af

Please sign in to comment.