Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPTAGTest KDTReconstructTest failure: Assertion `quantizer' failed. #315

Open
pabs3 opened this issue Jul 10, 2022 · 1 comment
Open

SPTAGTest KDTReconstructTest failure: Assertion `quantizer' failed. #315

pabs3 opened this issue Jul 10, 2022 · 1 comment

Comments

@pabs3
Copy link

pabs3 commented Jul 10, 2022

Describe the bug
The KDTReconstructTest test fails due to an assert.

To Reproduce
Steps to reproduce the behavior:

  1. Build SPTAG
  2. Run SPTAGTest
  3. See error

** To Fix**
Copy commit 1e87978 on the try-dispatcher branch by @PhilipBAdams from May 2022 to the main branch.

Expected behavior
The test should succeed.

Screenshots

SPTAGTest: ./Test/src/ReconstructIndexSimilarityTest.cpp:169: void GenerateReconstructData(std::shared_ptr<SPTAG::VectorSet>&, std::shared_ptr<SPTAG::VectorSet>&, std::shared_ptr<SPTAG::VectorSet>&, std::shared_ptr<SPTAG::MetadataSet>&, std::shared_ptr<SPTAG::VectorSet>&, std::shared_ptr<SPTAG::VectorSet>&, SPTAG::DistCalcMethod, int, std::shared_ptr<SPTAG::COMMON::IQuantizer>&) [with R = float]: Assertion `quantizer' failed.

Desktop:

  • OS: Debian
  • Browser None
  • Version 12 (bookworm)

Additional context
Add any other context about the problem here.

@pabs3
Copy link
Author

pabs3 commented Jul 10, 2022

Looks like merging #294 would also fix this issue, since the try-dispatcher branch is for that PR. @PhilipBAdams could you submit a separate PR for the test fix please?

pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Jul 10, 2022
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Jul 12, 2022
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Jul 18, 2022
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Jul 26, 2022
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Nov 13, 2022
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Feb 5, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Feb 6, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Mar 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Mar 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Mar 25, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Mar 25, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue May 3, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue May 10, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Jun 16, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
pabs3 pushed a commit to pabs3/SPTAG that referenced this issue Jul 20, 2023
Cherry-picked-from: commit 1e87978
Fixes: microsoft#315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant