Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating CNI binaries+scripts for flannel host-gw #282

Merged
merged 3 commits into from
Nov 21, 2018
Merged

updating CNI binaries+scripts for flannel host-gw #282

merged 3 commits into from
Nov 21, 2018

Conversation

daschott
Copy link
Contributor

@daschott daschott commented Nov 21, 2018

CNI binary changes:

  • Includes new win-bridge binaries
  • Fixes leaking endpoints issue + DNS suffix not being programmed (creds to @nagieseker)
  • Includes sample CNI config file

Scripts changes:

  • New parameter for interface names to create HNS network on top of
  • Installimages.ps1 & Dockerfile updated for new mcr.microsoft.com registry
  • Kubelet & kube-proxy logging enabled by default (will only print errors to screen)
  • New parameter for specifying logging directory (defaults to C:\k)
  • Moved around some of the download logic so files don't get overwritten by user changes done in C:\k directory
  • Fixed timing issue of prematurely starting flanneld.exe after vSwitch creation causing it to get stuck on "Waiting for network to be ready".

Outstanding issues for future PR:

  • need to investigate warning messages from kubelet logs, even if networking information is programmed correctly.
  • need to remove wincni @madhanrm @JMesser81 @rjaini can I remove the entire directory wincni directory + binary or have some automated tests taken a dependency? We hope to move to a new repo.

@daschott
Copy link
Contributor Author

@daschott daschott mentioned this pull request Nov 21, 2018
@JMesser81
Copy link
Contributor

/LGTM

@daschott
Copy link
Contributor Author

@JMesser81 thx. I don't have merge permissions, can you merge it?

@JMesser81 JMesser81 merged commit e1b7c4f into microsoft:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants