[.NET] Integration of new mode termed "TasksMode" in DatetimeOption.cs #2972
Conversation
| @@ -38,6 +38,11 @@ public enum DateTimeOptions | |||
| /// </summary> | |||
| NoProtoCache = 16, | |||
|
|
|||
| /// <summary> | |||
| /// NoProtoCache | |||
There was a problem hiding this comment.
I'd also personally prefer to use 2^20 as the value.
There was a problem hiding this comment.
Any specific reason for using 2^20 value.
There was a problem hiding this comment.
It's the highest available value.
There was a problem hiding this comment.
The file doesn't seem updated here.
.NET/Microsoft.Recognizers.Text.DateTime/Extractors/BaseMergedDateTimeExtractor.cs
Show resolved
Hide resolved
|
@Neelisha-saxena Build passed. So now only the new mirror DateTimeModel.json specs are missing. |
… test cases under default mode and tasksmode
|
I have implemented the suggestions. |
| @@ -18407,7 +18407,7 @@ | |||
| "Context": { | |||
| "ReferenceDateTime": "2019-12-15T01:00:00" | |||
| }, | |||
| "NotSupported": ".NET, javascript, python, java", | |||
| "NotSupported": "dotnet, javascript, python, java", | |||
| "Results": [ | |||
| { | |||
| "Text": "2000", | |||
There was a problem hiding this comment.
This should be empty as the real result should be nothing.
| @@ -38,6 +38,11 @@ public enum DateTimeOptions | |||
| /// </summary> | |||
| NoProtoCache = 16, | |||
|
|
|||
| /// <summary> | |||
| /// NoProtoCache | |||
There was a problem hiding this comment.
The file doesn't seem updated here.
| It should not treat 2005 as a daterange in statements like "Milk 2005." | ||
| (The year 2005 should be treated as a number only.) | ||
| */ | ||
| private bool ShouldSkipOnlyYear(ExtractResult er) |
There was a problem hiding this comment.
No need to do this in this PR, but it would be interesting if this mode-specific behaviours/code is isolated into it's own module/strategy.
Please move it along with new changes in a followup PR.
TasksMode: When the input text is in the form of tasks (i.e., Schedule 1:1 call on Monday), this mode modifies the value of datetime reference of the input text.
Implemented four-digit number handling rule under Tasksmode:
Should not treat a four-digit number as a "daterange" if the input text does not include other reference of month or year. It should not treat 2005 as a daterange in statements like "Total no of milk packet is 2005."